Call step(...) in enableOutputs() to ensure motor pins are driven in … #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case there was a previous call to disableOutputs()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition to enableOutputs() to ensure motor pins are driven.
Previously pins were turned off in disable and remained off until the first call to step() following a call to enableOutputs(). In situations where multiple steppers contribute to moving an effector (5 link robot for example) an enabled stepper that hasn't been moved could be pushed around by a moving stepper connected to a common effector. This update fixes the issue by ensuring that all enabled motors have their coils powered when enabled.